Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Gregory Ashton
  • PyFstat
  • Issues
  • #2
Closed
Open
Issue created Jul 14, 2017 by David Keitel@dkeitelMaintainer

why int(fmin) in run_makefakedata?

Hi again Greg, last one from me for now, and since I don't know if it's a simple bug or an intended hack, this is just an issue and not a merge request yet: Writer.run_makefakedata() has the line

cl.append('--fmin={}'.format(int(self.fmin)))

which, if I'm trying to work with a relatively narrow band around the injection Freq, will make MFDv5 fail with a signal/datarange mismatch error, because the --Band is not increased and hence the whole SFT range is just shifted downwards, away from the injection.

For me just removing that int() and making sure myself that the band is wide enough seems to work fine in all use cases so far, though I guess you might have introduced it as an extra security padding? But in that case I'd suggest to increase the Band as well, and ideally to make it optional.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking