From e3a36059e9898c80245e581c11c304f2b89f6dc8 Mon Sep 17 00:00:00 2001 From: Oliver Bock <fidelity@obock.de> Date: Wed, 5 Mar 2008 19:00:16 +0000 Subject: [PATCH] Reduced explicitness git-svn-id: https://svn.origo.ethz.ch/fidelity@25 53d1999f-d1a8-4366-aa61-588fded17473 --- gui/ComponentItem.cpp | 10 +++++----- gui/MainWindow.cpp | 6 +++--- .../library/fabryperotcavity/fabryperotcavity.cpp | 6 +++--- votable/VOBinary.cpp | 2 +- votable/VOData.cpp | 6 +++--- votable/VOField.cpp | 4 ++-- votable/VOFits.cpp | 2 +- votable/VOParam.cpp | 2 +- votable/VOTR.cpp | 2 +- votable/VOTable.cpp | 2 +- votable/VOTableData.cpp | 2 +- votable/VOValues.cpp | 4 ++-- 12 files changed, 24 insertions(+), 24 deletions(-) diff --git a/gui/ComponentItem.cpp b/gui/ComponentItem.cpp index 8cd0644..13acf15 100644 --- a/gui/ComponentItem.cpp +++ b/gui/ComponentItem.cpp @@ -136,7 +136,7 @@ Fidelity::GUI::ComponentItem::ComponentItem(QPointer<IComponent> component) Fidelity::GUI::ComponentItem::~ComponentItem() { // Delete children and attached links - if(m_Label) {delete m_Label;} + if(m_Label) delete m_Label; for(int i = 0; i<m_LinkItemList->size(); ++i) { // Schedules link for deletion (wait for event loop!) @@ -148,10 +148,10 @@ Fidelity::GUI::ComponentItem::~ComponentItem() } // Clean up members - if(m_NodeItemList) {delete m_NodeItemList;} - if(m_LinkItemList) {delete m_LinkItemList;} - if(m_ParameterModel) {delete m_ParameterModel;} - if(m_Component) {delete m_Component;} + if(m_NodeItemList) delete m_NodeItemList; + if(m_LinkItemList) delete m_LinkItemList; + if(m_ParameterModel) delete m_ParameterModel; + if(m_Component) delete m_Component; } // Public methods diff --git a/gui/MainWindow.cpp b/gui/MainWindow.cpp index 77f0ffd..95f2aa2 100644 --- a/gui/MainWindow.cpp +++ b/gui/MainWindow.cpp @@ -51,12 +51,12 @@ Fidelity::GUI::MainWindow::MainWindow(QWidget* parent, Qt::WFlags fl) : QMainWin Fidelity::GUI::MainWindow::~MainWindow() { // Deletes also m_ComponentCache - if(m_ComponentFactory!=NULL) {delete m_ComponentFactory;} + if(m_ComponentFactory!=NULL) delete m_ComponentFactory; delete m_ComponentItemTable; delete m_ToolboxContents; delete m_WorkbenchScene; - if(m_ActiveEngine!=NULL) {delete m_ActiveEngine;} + if(m_ActiveEngine!=NULL) delete m_ActiveEngine; delete m_ZoomLevelActionGroup; delete m_EngineParamModel; delete m_GlobalsParamModel; @@ -523,7 +523,7 @@ void Fidelity::GUI::MainWindow::on_cmbEngine_currentIndexChanged(int index) QString identifier = cmbEngine->itemData(index).toString(); // Clean up before instantiating new engine - if(m_ActiveEngine!=NULL) {delete m_ActiveEngine;} + if(m_ActiveEngine!=NULL) delete m_ActiveEngine; if(!identifier.isEmpty()) { // Create engine instance based on chosen identifier diff --git a/plugins/components/library/fabryperotcavity/fabryperotcavity.cpp b/plugins/components/library/fabryperotcavity/fabryperotcavity.cpp index cc28122..d896143 100644 --- a/plugins/components/library/fabryperotcavity/fabryperotcavity.cpp +++ b/plugins/components/library/fabryperotcavity/fabryperotcavity.cpp @@ -41,9 +41,9 @@ Fidelity::Plugin::Component::FabryPerotCavity::~FabryPerotCavity() delete m_BeamNode1; delete m_BeamNode2; - if(m_MirrorWest) {delete m_MirrorWest;} - if(m_Space) {delete m_Space;} - if(m_MirrorEast) {delete m_MirrorEast;} + if(m_MirrorWest) delete m_MirrorWest; + if(m_Space) delete m_Space; + if(m_MirrorEast) delete m_MirrorEast; } void Fidelity::Plugin::Component::FabryPerotCavity::initAttributes() diff --git a/votable/VOBinary.cpp b/votable/VOBinary.cpp index 6f6538b..e3f2f4e 100644 --- a/votable/VOBinary.cpp +++ b/votable/VOBinary.cpp @@ -27,7 +27,7 @@ Fidelity::Common::VOBinary::VOBinary() Fidelity::Common::VOBinary::~VOBinary() { - if(m_Stream){delete m_Stream;} + if(m_Stream) delete m_Stream; } void Fidelity::Common::VOBinary::initAttributes() diff --git a/votable/VOData.cpp b/votable/VOData.cpp index 019b09b..9be1d52 100644 --- a/votable/VOData.cpp +++ b/votable/VOData.cpp @@ -27,9 +27,9 @@ Fidelity::Common::VOData::VOData() Fidelity::Common::VOData::~VOData() { - if(m_TableData) {delete m_TableData;} - if(m_Fits) {delete m_Fits;} - if(m_Binary) {delete m_Binary;} + if(m_TableData) delete m_TableData; + if(m_Fits) delete m_Fits; + if(m_Binary) delete m_Binary; } void Fidelity::Common::VOData::initAttributes() diff --git a/votable/VOField.cpp b/votable/VOField.cpp index 8ebe6b1..8ac29ae 100644 --- a/votable/VOField.cpp +++ b/votable/VOField.cpp @@ -27,8 +27,8 @@ Fidelity::Common::VOField::VOField() Fidelity::Common::VOField::~VOField() { - if(m_Values) {delete m_Values;} - if(m_LinkList) {delete m_LinkList;} + if(m_Values) delete m_Values; + if(m_LinkList) delete m_LinkList; } void Fidelity::Common::VOField::initAttributes() diff --git a/votable/VOFits.cpp b/votable/VOFits.cpp index 97988d6..3c16c0d 100644 --- a/votable/VOFits.cpp +++ b/votable/VOFits.cpp @@ -27,7 +27,7 @@ Fidelity::Common::VOFits::VOFits() Fidelity::Common::VOFits::~VOFits() { - if(m_Stream){delete m_Stream;} + if(m_Stream) delete m_Stream; } void Fidelity::Common::VOFits::initAttributes() diff --git a/votable/VOParam.cpp b/votable/VOParam.cpp index 87467c2..b0444d5 100644 --- a/votable/VOParam.cpp +++ b/votable/VOParam.cpp @@ -27,7 +27,7 @@ Fidelity::Common::VOParam::VOParam() Fidelity::Common::VOParam::~VOParam() { - if(m_Values){delete m_Values;} + if(m_Values) delete m_Values; delete m_LinkList; } diff --git a/votable/VOTR.cpp b/votable/VOTR.cpp index 863308a..317eeb9 100644 --- a/votable/VOTR.cpp +++ b/votable/VOTR.cpp @@ -33,7 +33,7 @@ VOTR::~VOTR() // iterate over list and delete all referenced entries while (!m_TDList->isEmpty()) { QPointer<VOTD> entry = m_TDList->takeFirst(); - if(entry) {delete entry;} + if(entry) delete entry; } delete m_TDList; diff --git a/votable/VOTable.cpp b/votable/VOTable.cpp index a751e3b..42b4cea 100644 --- a/votable/VOTable.cpp +++ b/votable/VOTable.cpp @@ -31,7 +31,7 @@ Fidelity::Common::VOTable::~VOTable() delete m_ParamList; delete m_GroupList; delete m_LinkList; - if(m_Data){delete m_Data;} + if(m_Data) delete m_Data; } void Fidelity::Common::VOTable::initAttributes() diff --git a/votable/VOTableData.cpp b/votable/VOTableData.cpp index b00f67d..fd08ec5 100644 --- a/votable/VOTableData.cpp +++ b/votable/VOTableData.cpp @@ -34,7 +34,7 @@ VOTableData::~VOTableData() unsigned long size = m_TRList->size(); for (unsigned long i = 0; i < size; ++i) { - if(m_TRList->at(i)) {delete m_TRList->at(i);} + if(m_TRList->at(i)) delete m_TRList->at(i); } delete m_TRList; diff --git a/votable/VOValues.cpp b/votable/VOValues.cpp index 4126711..7237c57 100644 --- a/votable/VOValues.cpp +++ b/votable/VOValues.cpp @@ -27,8 +27,8 @@ Fidelity::Common::VOValues::VOValues() Fidelity::Common::VOValues::~VOValues() { - if(m_Min){delete m_Min;} - if(m_Max){delete m_Max;} + if(m_Min) delete m_Min; + if(m_Max) delete m_Max; delete m_OptionList; } -- GitLab