mgr: remove SET_LOCALE from DlgDiagnosticLogFlags.cpp
SET_LOCALE is no-op when using per-thread locales making SET_LOCALE unnecessary. When per-thread locales are not available using SET_LOCALE in CDlgDiagnosticLogFlags can cause Manager to get stuck to C locale. The lifetime of two SET_LOCALE objects can be interleaved if log flags are loaded or saved and an async RPC is launched at the same time. If the lifetimes are interleaved the first object sets global locale to C. The second object saves the global locale that was set to C by the first object. First object restores the global locale correctly. After that the second object incorrectly restores the global locale to C.
Showing with 0 additions and 3 deletions