Commit 558227bb authored by Bruce Allen's avatar Bruce Allen
Browse files

Added comment about sign conventions for the source

parent e80490ae
......@@ -536,6 +536,14 @@ void PulsarAnimationWidget::updateCameraPosition(const double angleH, const doub
void PulsarAnimationWidget::setSourceInclination(const double degrees)
{
// This sign convention differs from my notes. In my notes,
// increasing psi means that the orbital ellipse rotates CCW when
// viewed from above. But the convention in LAL is that increasing
// psi rotates the ellipse CCW when viewed from Earth, and CW when
// viewed from above. So I have adjusted this code to be
// consistent with LAL, and inserted a factor of -1 in my code.
// Bruce
m_sourceInclination = degrees;
updatePulseProfile();
......@@ -596,6 +604,14 @@ void PulsarAnimationWidget::updatePulseProfile()
struct OutputStruct out;
in.iota = m_sourceIota;
// This sign convention for in.psi differs from my notes. In my
// notes, increasing psi means that the orbital ellipse rotates
// CCW when viewed from above. But the convention in LAL is that
// increasing psi rotates the ellipse CCW when viewed from Earth,
// and CW when viewed from above. So I have adjusted this code to
// be consistent with LAL, and inserted a factor of -1 in my code.
// Bruce
in.psi = m_sourceInclination;
in.orientation[0] = m_LLOAngle;
in.orientation[1] = m_LHOAngle;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment