Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
einsteinathome
pulsatingscience
Commits
558227bb
Commit
558227bb
authored
Sep 30, 2017
by
Bruce Allen
Browse files
Added comment about sign conventions for the source
parent
e80490ae
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/pulsaranimationwidget.cpp
View file @
558227bb
...
...
@@ -536,6 +536,14 @@ void PulsarAnimationWidget::updateCameraPosition(const double angleH, const doub
void
PulsarAnimationWidget
::
setSourceInclination
(
const
double
degrees
)
{
// This sign convention differs from my notes. In my notes,
// increasing psi means that the orbital ellipse rotates CCW when
// viewed from above. But the convention in LAL is that increasing
// psi rotates the ellipse CCW when viewed from Earth, and CW when
// viewed from above. So I have adjusted this code to be
// consistent with LAL, and inserted a factor of -1 in my code.
// Bruce
m_sourceInclination
=
degrees
;
updatePulseProfile
();
...
...
@@ -596,6 +604,14 @@ void PulsarAnimationWidget::updatePulseProfile()
struct
OutputStruct
out
;
in
.
iota
=
m_sourceIota
;
// This sign convention for in.psi differs from my notes. In my
// notes, increasing psi means that the orbital ellipse rotates
// CCW when viewed from above. But the convention in LAL is that
// increasing psi rotates the ellipse CCW when viewed from Earth,
// and CW when viewed from above. So I have adjusted this code to
// be consistent with LAL, and inserted a factor of -1 in my code.
// Bruce
in
.
psi
=
m_sourceInclination
;
in
.
orientation
[
0
]
=
m_LLOAngle
;
in
.
orientation
[
1
]
=
m_LHOAngle
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment