Commit 0e08d581 authored by Daniel Brown's avatar Daniel Brown
Browse files

fixing lens issues

parent 66c2a0df
Pipeline #1224 passed with stage
......@@ -3,7 +3,7 @@ from __future__ import division
from __future__ import print_function
from __future__ import unicode_literals
__version__ = "1.0.7"
__version__ = "1.0.8"
# This flag is used to switch on the gui features in pkat at import time
USE_GUI = False
......@@ -987,34 +987,30 @@ class isolator(Component):
return self._svgItem
class lens(Component):
def __init__(self, name, node1, node2, f=1):
def __init__(self, name, node1, node2, f=1, p=None):
Component.__init__(self, name)
if not ((f is None) ^ (p is None)):
raise pkex.BasePyKatException("Specify either a focal length or power, not both.")
self._svgItem = None
self.__f = Param("f", self, SIfloat(f))
self.__p = Param("p", self, None)
self.__p = Param("p", self, SIfloat(p))
def f(self):
if self.__f is not None:
return self.__f
return 1/self.__p
def f(self): return self.__f
def f(self, value):
self.__f.value = SIfloat(value)
self.__p.value = None
def p(self):
if self.__p is not None:
return self.__p
return 1/self.__f
def p(self): return self.__p
def p(self, value):
self.__p.value = SIfloat(value)
self.__f.value = None
......@@ -1023,18 +1019,23 @@ class lens(Component):
def parseFinesseText(text):
values = text.split()
if values[0] != "lens":
if not values[0].startswith("lens"):
raise pkex.BasePyKatException("'{0}' not a valid Finesse lens command".format(text))
alt = values[0].endswith("*")
values.pop(0) # remove initial value
if len(values) == 4:
return lens(values[0], values[2], values[3], values[1])
if not alt:
return lens(values[0], values[2], values[3], f=values[1], p=None)
return lens(values[0], values[2], values[3], f=None, p=values[1])
raise pkex.BasePyKatException("Lens Finesse code format incorrect '{0}'".format(text))
def getFinesseText(self):
if self.__p is None:
if self.__p.value is None:
rtn = ['lens {0} {1} {2} {3}'.format(, self.f.value, self.nodes[0].name, self.nodes[1].name)]
rtn = ['lens* {0} {1} {2} {3}'.format(, self.p.value, self.nodes[0].name, self.nodes[1].name)]
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment