pykat issueshttps://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues2018-05-10T17:46:25Zhttps://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues/6Support for loss in isolator component2018-05-10T17:46:25ZDaniel ToyraSupport for loss in isolator componentCurrently PyKat doesn't accept loss for the isolator component. Can be fixed in the method `parseFinesseText()` of the isolator class in the file **components.py**.Currently PyKat doesn't accept loss for the isolator component. Can be fixed in the method `parseFinesseText()` of the isolator class in the file **components.py**.Daniel ToyraDaniel Toyrahttps://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues/5Detector output format in PyKat when using x2axis in Finesse2018-05-10T17:46:25ZDaniel ToyraDetector output format in PyKat when using x2axis in FinesseWith one `xaxis` and `yaxis abs:deg` or `yaxis re:im`, the output from `out['detector_name']` is an array of complex numbers.
If we add an `x2axis`, the output from `out['detector_name']` is a 3D matrix, where for
* `yaxis re:im` the...With one `xaxis` and `yaxis abs:deg` or `yaxis re:im`, the output from `out['detector_name']` is an array of complex numbers.
If we add an `x2axis`, the output from `out['detector_name']` is a 3D matrix, where for
* `yaxis re:im` the output from `out['detector_name'][0]` is a 2D matrix with the real parts and `out['detector_name'][1]` is a 2D matrix with the imaginary parts.
* `yaxis abs:deg` the output from `out['detector_name'][0]` is a 2D matrix with the absolute values and `out['detector_name'][1]` is a 2D matrix with the phases in degrees.
I think the outputs with one and two x-axes should be consistent. I suggest that we change the output when using x2axis into complex number as well.https://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues/4Testing git reference2018-05-10T17:46:25ZDaniel BrownTesting git referenceIn `testing/web_server.py`it references the old testing suite on GitMaster. This needs to be updates to a GitLab repo once we have decided where and how to move the test files.In `testing/web_server.py`it references the old testing suite on GitMaster. This needs to be updates to a GitLab repo once we have decided where and how to move the test files.https://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues/3Add more testing for maps2018-05-10T17:46:25ZDaniel BrownAdd more testing for mapsIn `pykat/test/test_scripts/physics/test_maps.py` we need to add checks to ensure that each of the methods are working. The script should check that all the various maps get created without exceptions. Currently this is only simply wri...In `pykat/test/test_scripts/physics/test_maps.py` we need to add checks to ensure that each of the methods are working. The script should check that all the various maps get created without exceptions. Currently this is only simply written for `curvedmap`.
Methods that generate a numerical output should print the result (assuming it is a small array of numbers) and compare them to values known to be true using `assert`, e.g.:
```
reference = [1,2,3,4]
output = method.compute()
assert(reference == output)
```
For large data save known output as numpy file which is loaded.
There are now various map format readers. A format from each should be included in the test folder and a script written to read the maps.Daniel ToyraDaniel Toyrahttps://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues/2curvedmap error2018-05-10T17:46:25ZDaniel Browncurvedmap errorIf you run `pykat/test/test_scripts/physics/test_maps.py`, the following error comes up:
```
Traceback (most recent call last):
File "test_maps.py", line 12, in <module>
itm = curvedmap('itm_Rc', 1, 1, 1)
File "/Users/ddb/...If you run `pykat/test/test_scripts/physics/test_maps.py`, the following error comes up:
```
Traceback (most recent call last):
File "test_maps.py", line 12, in <module>
itm = curvedmap('itm_Rc', 1, 1, 1)
File "/Users/ddb/git/pykat/pykat/optics/maps.py", line 1651, in __init__
surfacemap.__init__(self, name, "phase reflection", size, (np.array(size)+1)/2.0, step_size, 1e-6)
File "/Users/ddb/git/pykat/pykat/optics/maps.py", line 59, in __init__
self.Rc = Rc
File "/Users/ddb/git/pykat/pykat/optics/maps.py", line 1662, in Rc
xx, yy = np.meshgrid(self.x, self.y)
File "/Users/ddb/git/pykat/pykat/optics/maps.py", line 188, in x
return self.step_size[0] * (np.array(range(0, self.data.shape[1])) - self.center[0])
TypeError: 'int' object is not subscriptable
```Daniel ToyraDaniel Toyrahttps://gitlab.aei.uni-hannover.de/finesse/pykat/-/issues/1Warning with fsig frequency set to 02018-05-10T17:46:25ZDaniel BrownWarning with fsig frequency set to 0When applying fsigs with:
`kat.signals.apply(kat.M_ETM_HR.phi, 1, 180) # amplitude = 1, phase = 180 degree`
You see the error:
```
------------------------------------------------------------
Error from Finesse:
*** Error: Lin...When applying fsigs with:
`kat.signals.apply(kat.M_ETM_HR.phi, 1, 180) # amplitude = 1, phase = 180 degree`
You see the error:
```
------------------------------------------------------------
Error from Finesse:
*** Error: Line `fsig sig_M_ETM_HR_phi M_ETM_HR phase 0
180.0 1.0 ': Signal frequency must be positive and greater
than 0Hz
------------------------------------------------------------
```
Need a check before running file whether fsigs are used and if so should be greater than 0
Daniel BrownDaniel Brown