diff --git a/smartmontools/ChangeLog b/smartmontools/ChangeLog index 955f89880644cc253b1c673035453699bd8946b4..ce9dcdfccea7a6eb55fdcc86ff27dc7d7c0f015a 100644 --- a/smartmontools/ChangeLog +++ b/smartmontools/ChangeLog @@ -1,5 +1,9 @@ $Id$ +2022-02-25 Douglas Gilbert <dgilbert@interlog.com> + + NEWS: update for changes in previous commit + 2022-02-25 Douglas Gilbert <dgilbert@interlog.com> smartctl.cpp, scsiprint.cpp: extend --log=defects option so it diff --git a/smartmontools/NEWS b/smartmontools/NEWS index 390185f039ac525270f164e93f9db05f39d2cdcc..8ab3f5ed0e36c930389a2e5f6a93b57a0345d1b2 100644 --- a/smartmontools/NEWS +++ b/smartmontools/NEWS @@ -11,11 +11,15 @@ Summary: smartmontools release 7.3 - smartctl '-j': Many additions to the JSON output for SCSI/SAS devices. - smartctl '-j': JSON output always includes timestamp, regardless of '-i'. - smartctl '-i' and '--identify': ATA ACS-5 enhancements. +- smartctl '-l defects': additionally works for SCSI Pending Defects log + subpage. +- smartctl '-l envrep': Prints SCSI Environmental Reporting log subpage. - smartctl '-l scterc[,R,W],p': Gets/sets the persistent power-on values. - smartctl '-l scterc,reset': Restores to manufacturer's default values. -- smartctl '-l scttemp': Prints SCSI Environmental Reporting log subpage. - smartctl '-l tapedevstat': Prints SCSI Tape Device Statistics log page. - smartctl '-l tapealert': Prints SCSI Tape Alert log page. +- smartctl '-l zdevstat': Prints SCSI Zoned Block Device Statistics log + subpage. - smartctl '-H': No longer checks and clears the SCSI Tape Alert log page unless the option is given twice. - smartctl '-H': No longer sets bit 2 of exit status if ATA attributes are diff --git a/smartmontools/scsiprint.cpp b/smartmontools/scsiprint.cpp index da10f2e116306f6cb531146ffe3cb77c1789c141..f711d6685bceb98a72cb8fe73d4446a4576ab89c 100644 --- a/smartmontools/scsiprint.cpp +++ b/smartmontools/scsiprint.cpp @@ -3400,21 +3400,21 @@ scsiPrintMain(scsi_device * device, const scsi_print_options & options) scsiGetSupportedLogPages(device); checkedSupportedLogPages = true; } - if (options.smart_error_log) { + if (options.smart_error_log) { scsiPrintErrorCounterLog(device); any_output = true; - } + } if (gPendDefectsLPage) { scsiPrintPendingDefectsLPage(device); any_output = true; - } - if (options.smart_error_log) { + } + if (options.smart_error_log) { if (1 == scsiFetchControlGLTSD(device, modese_len, 1)) { pout("\n[GLTSD (Global Logging Target Save Disable) set. " "Enable Save with '-S on']\n"); any_output = true; - } - } + } + } } if (options.smart_selftest_log) { if (! checkedSupportedLogPages) { diff --git a/smartmontools/scsiprint.h b/smartmontools/scsiprint.h index 771d5a320a41b7e44f8559cf5697c83747509775..beb3322ed7ea0ade077e822d742b2665faec845e 100644 --- a/smartmontools/scsiprint.h +++ b/smartmontools/scsiprint.h @@ -58,7 +58,7 @@ struct scsi_print_options bool set_standby_now = false; // set drive to standby bool set_active = false; // set drive to active - int health_opt_count = 0; // TapeAlert log page only read if this value > 1 + int health_opt_count = 0; // TapeAlert log page only read if this value > 1 }; int scsiPrintMain(scsi_device * device, const scsi_print_options & options);