From c530cb2efde331f12ad1a7e49db3321ce612f185 Mon Sep 17 00:00:00 2001
From: ballen4705 <ballen4705@4ea69e1a-61f1-4043-bf83-b5c94c648137>
Date: Fri, 28 Nov 2003 23:21:58 +0000
Subject: [PATCH] Better comments
git-svn-id: https://smartmontools.svn.sourceforge.net/svnroot/smartmontools/trunk@1311 4ea69e1a-61f1-4043-bf83-b5c94c648137
---
sm5/atacmds.c | 8 +++++---
sm5/atacmds.cpp | 8 +++++---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/sm5/atacmds.c b/sm5/atacmds.c
index b4de9ee2c..7f62076c5 100644
--- a/sm5/atacmds.c
+++ b/sm5/atacmds.c
@@ -32,7 +32,7 @@
#include "extern.h"
#include "utility.h"
-const char *atacmds_c_cvsid="$Id: atacmds.c,v 1.131 2003/11/26 05:57:46 ballen4705 Exp $" ATACMDS_H_CVSID EXTERN_H_CVSID UTILITY_H_CVSID;
+const char *atacmds_c_cvsid="$Id: atacmds.c,v 1.132 2003/11/28 23:21:58 ballen4705 Exp $" ATACMDS_H_CVSID EXTERN_H_CVSID UTILITY_H_CVSID;
// to hold onto exit code for atexit routine
extern int exitstatus;
@@ -879,15 +879,16 @@ int ataWriteSelectiveSelfTestLog(int device){
}
#endif
-
// This corrects some quantities that are byte reversed in the SMART
-// ATA ERROR LOG
+// ATA ERROR LOG.
void fixsamsungerrorlog(struct ata_smart_errorlog *data){
int i,j;
+ // FIXED IN SAMSUNG -25 FIRMWARE???
// Device error count in bytes 452-3
swap2((char *)&(data->ata_error_count));
+ // FIXED IN SAMSUNG -22a FIRMWARE
// step through 5 error log data structures
for (i=0; i<5; i++){
// step through 5 command data structures
@@ -900,6 +901,7 @@ void fixsamsungerrorlog(struct ata_smart_errorlog *data){
return;
}
+// NEEDED ONLY FOR SAMSUNG -22 (some) -23 AND -24?? FIRMWARE
void fixsamsungerrorlog2(struct ata_smart_errorlog *data){
// Device error count in bytes 452-3
swap2((char *)&(data->ata_error_count));
diff --git a/sm5/atacmds.cpp b/sm5/atacmds.cpp
index 442d08bae..d4f0dd768 100644
--- a/sm5/atacmds.cpp
+++ b/sm5/atacmds.cpp
@@ -32,7 +32,7 @@
#include "extern.h"
#include "utility.h"
-const char *atacmds_c_cvsid="$Id: atacmds.cpp,v 1.131 2003/11/26 05:57:46 ballen4705 Exp $" ATACMDS_H_CVSID EXTERN_H_CVSID UTILITY_H_CVSID;
+const char *atacmds_c_cvsid="$Id: atacmds.cpp,v 1.132 2003/11/28 23:21:58 ballen4705 Exp $" ATACMDS_H_CVSID EXTERN_H_CVSID UTILITY_H_CVSID;
// to hold onto exit code for atexit routine
extern int exitstatus;
@@ -879,15 +879,16 @@ int ataWriteSelectiveSelfTestLog(int device){
}
#endif
-
// This corrects some quantities that are byte reversed in the SMART
-// ATA ERROR LOG
+// ATA ERROR LOG.
void fixsamsungerrorlog(struct ata_smart_errorlog *data){
int i,j;
+ // FIXED IN SAMSUNG -25 FIRMWARE???
// Device error count in bytes 452-3
swap2((char *)&(data->ata_error_count));
+ // FIXED IN SAMSUNG -22a FIRMWARE
// step through 5 error log data structures
for (i=0; i<5; i++){
// step through 5 command data structures
@@ -900,6 +901,7 @@ void fixsamsungerrorlog(struct ata_smart_errorlog *data){
return;
}
+// NEEDED ONLY FOR SAMSUNG -22 (some) -23 AND -24?? FIRMWARE
void fixsamsungerrorlog2(struct ata_smart_errorlog *data){
// Device error count in bytes 452-3
swap2((char *)&(data->ata_error_count));
--
GitLab