Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Gregory Ashton
  • PyFstat
  • Issues
  • #15
Closed
Open
Issue created Jul 23, 2019 by David Keitel@dkeitelMaintainer

enable optional use of resampling algorithm

As reported by Pep Covas, we currently seem to have the demod F-Stat algorithm hardcoded. My first suggestion was to just add a new "method" argument to the "ComputeFstat(BaseSearchClass)" class and change the line

FstatOAs.FstatMethod = lalpulsar.FstatOptionalArgsDefaults.FstatMethod

in core.py accordingly.

Pep tested something like this and got:

XLAL Error - XLALComputeFstatResamp (ComputeFstat_Resamp.c:470): Resampling does not currently support atoms per detector
XLAL Error - XLALComputeFstatResamp (ComputeFstat_Resamp.c:470): Invalid argument
XLAL Error - XLALComputeFstat (ComputeFstat.c:828): Check failed: (input->method_funcs.compute_func) ( *Fstats, common, input->method_data ) == XLAL_SUCCESS
XLAL Error - XLALComputeFstat (ComputeFstat.c:828): Internal function call failed: Invalid argument

So the most difficult part would be to look into how the semicoherent search could be adapted to not use the atoms flag.

Edited Jul 23, 2019 by David Keitel
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking