Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Gregory Ashton
  • PyFstat
  • Merge requests
  • !6

Renames sftfilepath -> sftfilepattern

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gregory Ashton requested to merge renaming_sftfilepath_to_pattern into master Jul 18, 2017
  • Overview 1
  • Commits 1
  • Changes 15

This renames the input sftfilepath to sftfilepattern and adds documentation on how that should be used, i.e. a colon separated list of wildstring or exact matches. In globbing for all matches, the colon split is added in. sftfilepath is still used by Writer since an exact path is known.

@dkeitel I've submitted this as a merge request to get your input, both because it effects a previous bug you fixed, and it may require you to rename a variable in all scripts (sftfilepath -> sftfilepattern). My reasoning is that the name better reflects its use: it will be more typical to provide a pattern than a path. Are you happy with this change?

Cheers,

Greg

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: renaming_sftfilepath_to_pattern