renamed library and header to 'eclfft' to avoid conflicts with clFFT
For the OpenCL version of the Resampling FStat we want to link this OpenCL FFT library together with the clFFT (https://github.com/clMathLibraries/clFFT , see https://gitlab.aei.uni-hannover.de/einsteinathome/lalsuite/issues/5). This PR therefore renames the library and headers to 'eclfft' (E@H's OpenCL FFT) to avoid naming conflcts with the clFFT. Note: this will require to change all code that uses this library, but that should only concern the BRP search code.
Merge request reports
Activity
I don't understand the original motivation to use both libraries in the same app. Is that due to the latest performance findings regarding our library? The point is, this change requires updates to all our our existing apps (BRP/FGRP, codes and makefiles) and I'm not sure all of that effort is really justified. One could also think about patching the new library on build instead, as that would minimize the number of required changes. That said, I don't know enough background so that's your call to make (and work to carry out).
- The concept of the LALPulsar ComputeFStat API is to compile & link every possibility at compile-time and select which one to use at run-time. Besides that it allows for easier comparison of results and timing.
- The "OpenCL FStat" method is not only meant for E@H applications, but instead for general use in "CW" / "pulsar" applications of LALSuite (e.g. to be used on Atlas). There is no canonical build script in which you could "patch" the "library build".
- The only affected code I know of is BRP (FGRP is not using this lib), and I'm pretty sure that this could be done automatically (search&replace). We might need a new BRP app (version) release anyway (for GPDR conformance).
That being said, I could add an "install" target to the Makefiles instead that installs the header and library with different names and would only be called for subsequent library installation for e.g. LALSuite. This may suit everyone's needs better.
assigned to @brevilo
mentioned in commit a7bd5410