Makefile improvements

• allow to build shared and static versions separately
• fix OSX shared build

Apparently for use in LALPulsar ResamplingOpenCL it's occasionally necessary to build a shared version of this library. This modification allows to build (and install) static and shared versions separately, and also fixes building the shared version on Mac OSX.

added 1 commit

• aca23d27 - fix MinGW build

Compare with previous version

added 1 commit

• e01a2fd1 - Makefile: improve selection of possible include paths

Compare with previous version

This will always be overwritten If I see right as AMDAPPSDKROOT and NVIDIA_SDK_INSTALL_PATH are always defined in this Makefile

changed this line in version 4 of the diff

Thanks, good catch! Well, at least you could override by setting OPENCL_INCLUDE or CUDA_INSTALL_PATH, but indeed the AMDAPPSDKROOT will never be used. Need to think about this some more, I hate to hardcode paths in Makefiles of (ultimately) public projects.

may it would be nicer to have a install-shared install-static and install. Now a make shared install will also install the static library even when you have a clean build dir, but a make static install will only install the static library. I think it is because $(TARGET2) is not on the dependencies list for install

Well, actually the idea here is to install whatever has been built (hence the cp libeclfft.*), so actually $(TARGET) should not be on the dependency list of 'install:'.

changed this line in version 5 of the diff

@maxBensch This is meant to fix it. Have a try!

this looks good to me.

added 2 commits

• 9ba1bd5c - fix selection of possible include paths
• 6123b933 - allow static and shared builds from top level

Compare with previous version

added 1 commit

• cec37b69 - don't force building the static version when installing

Compare with previous version

This doesn't work for me as it does not build the example (make: 'example' is up to date. in a clean builddir). Renaming example to something else works. As example is also the default target, it should also respect the OPENCL_INCLUDE and CUDA_INSTALL_PATH environment variables.

Thanks. I shouldn't have used the directory name as a target name. Will fix it.

changed this line in version 6 of the diff

added 1 commit

• 06adfda0 - Makefile: renamed target 'sample' to avoid conflict with directory name

Compare with previous version

@maxBensch any further comments on this? If not, I'll merge that.

I would also include OPENCL_INCLUDE and CUDA_INSTALL_PATH in the Makefile from the example for completeness, but apart from that I have no comments on this more.

added 1 commit

• 4967ca64 - example/Makefile: adapt the include path selection from src/Makefile here

Compare with previous version

@maxBensch like 4967ca64 ?

@bema yes, this is good. No further comments then.

merged

mentioned in commit 137b4784