Skip to content
Snippets Groups Projects
Commit 31995ed8 authored by Daniel Brown's avatar Daniel Brown
Browse files

Fixes #1 - warning on negative or zero fsig

parent 0e08d581
No related branches found
No related tags found
No related merge requests found
...@@ -642,13 +642,19 @@ class Signals(object): ...@@ -642,13 +642,19 @@ class Signals(object):
@property @property
def f(self): return self.__f def f(self): return self.__f
@f.setter @f.setter
def f(self,value): self.__f.value = SIfloat(value) def f(self,value):
v = SIfloat(value)
if v <= 0:
raise pkex.BasePyKatException("Signal frequency must be greater than 0.")
self.__f.value = SIfloat(value)
def __init__(self, kat): def __init__(self, kat):
self._default_name = "fsignal" self._default_name = "fsignal"
self.targets = [] self.targets = []
self._params = [] self._params = []
self.__f = Param("f", self, 0) self.__f = Param("f", self, None)
self._kat = kat self._kat = kat
def _register_param(self, param): def _register_param(self, param):
...@@ -667,10 +673,11 @@ class Signals(object): ...@@ -667,10 +673,11 @@ class Signals(object):
def getFinesseText(self): def getFinesseText(self):
rtn = [] rtn = []
if len(self.targets) == 0 and (self.f != 0 and self.f is not None): if self.f.value is not None and self.f is not None:
if len(self.targets) == 0:
rtn.append("fsig {name} {frequency}" rtn.append("fsig {name} {frequency}"
.format(name = self.name, .format(name = self.name,
frequency=str(self.f))) frequency=str(self.f.value)))
else: else:
for t in self.targets: for t in self.targets:
rtn.extend(t.getFinesseText()) rtn.extend(t.getFinesseText())
...@@ -679,7 +686,7 @@ class Signals(object): ...@@ -679,7 +686,7 @@ class Signals(object):
.format(name = t.name, .format(name = t.name,
comp=t.owner, comp=t.owner,
target=t.target, target=t.target,
frequency=str(self.f), frequency=str(self.f.value),
phase=str(t.phase), phase=str(t.phase),
amplitude=str(t.amplitude if t.amplitude != None else ""))) amplitude=str(t.amplitude if t.amplitude != None else "")))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment