Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Gregory Ashton
  • PyFstat
  • Issues
  • #11
Closed
Open
Issue created Dec 20, 2017 by Gregory Ashton@GregAshtonOwner

Move transient gridded search to separate class

Hi @dkeitel ,

Currently, I think you are using GridSearch to run your transient grid searches, is that correct? If you continue to develop this, it may make sense to create a specific subclass, say TransientGridSearch. Basically, you do something like

class TransientGridSearch(GridSearch)
    def __init__ ...

This way, TransientGridSearch inherits all methods from GridSearch, but then overwrite any parts it needs to modify.

The benefit is, any other methods which subclass GridSearch, doesn't need to worry about the transient parts (and hence changes to the transient parts won't break anything else).

Is there any reason why this wouldn't work? If not, I'll have a look at creating a patch and seeing what you think

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking