Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

ATTENTION: This Gitlab instance will undergo extended maintenance on 2023-04-12 at 06:00 UTC. The downtime will approximately take 1 hour. Please plan ahead accordingly. For questions please contact atlas_admin@aei.mpg.de

  • Gregory Ashton
  • PyFstat
  • Merge requests
  • !11

transients: fix window=none case and allow custom dt0, dtau

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Keitel requested to merge transientParamsFixes into master Jan 10, 2018
  • Overview 1
  • Commits 1
  • Changes 2

This fixes the windowRange struct for type=none, in accordance with XLALComputeTransientFstatMap. And since that meant I needed to touch the if-else construct for default t0, tau spacings anyway, I chose this opportunity to make them user-configurable too.

It seems somewhat messy and contrary to the classes idea to keep adding extra transient parameters to the core ComputeFstat class. But we talked in the past about a "hybrid" MCMC search that only samples in Doppler params, with the transient params marginalised over a grid, and I think to keep that option open, it's probably best to continue in this way.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: transientParamsFixes