Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Gregory Ashton
  • PyFstat
  • Merge requests
  • !18

ephemerides finding improvement

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Keitel requested to merge find-ephems into master Aug 02, 2018
  • Overview 0
  • Commits 2
  • Changes 2

Hi @GregAshton , I was trying to completely isolate a PyFstat installation inside a venv without relying on anything in my home directory, and so I came up with this proposed solution to get ephemerides paths from the $LALPULSAR_DATADIR env variable. In principle this could be made smarter about which version of the files it chooses, but for now I've just told it to try the new 00-40-DE421 and old 00-19-DE421 standards, then fall back to asking for manual user input. Any other use case can still be covered by the conf file approach, which is still checked first and hence can override the env variable. I also added an error catching for the case where the file exists, but is missing one or both of the actual path definitions, and updated the README.

Do you think this covers all relevant cases?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: find-ephems