Make tests more robust

This all looks fine to me. But, @dkeitel this removes pycuda as a strict dependency: is that okay with you?

mh, I realize I should have documented this commit better, as now I can't even remember what problem I had with this ... Ultimately I do think this should be an optional dependency though, as the majority of pyFstat certainly works without pycuda, and should therefore not require it to install.

I'll try and dig out/reproduce what specific problem this caused for me ...

The _optional_import function was already designed to make the import safe, but it looks like the error message checking was too strict for @ReinhardPrix 's platforms...? Just out of interest, do you remember which type of error they throw instead? But in principle the change looks fine; if there's some weird failure mode where the package is available but still fails to import (which I guess I initially had in mind with that except statement), the log message plus whatever fails next down the pipeline should be clear enough.

As for the dependencies, I had only listed pycuda as "optional" in the README anyway, so honestly I'm not sure what it's doing in setup.py in the first place, and sure it can be removed from there.

I think a successfull test pipeline for this MR still requires Greg being connected with the right machine, as there's no online CI set up.

resolved all threads

Yep, the machine which ran the C.I. tests is currently somewhere in the AEI (or possibly shipped back to the supplier?) so it will never pass right now (and perhaps should just be switched off. I'll merge this in.

merged

mentioned in commit d569dc90

@GregAshton could you add me as a maintainer to this project, I can see if I can setup a suitable CI machine/runner for this.

Yep certainly.

great, thanks. I've activated a little runner + CI now (MR !22 (merged)).

Make tests more robust

Merge request reports

Activity