install issues

I'm unable to install from the current version 6057a8ed under either python 2 or 3. I'll make a branch for fixing it under py3 first, then see if py2 compatibility is still possible too.

Also now that getting lalsuite from pip can be considered mature, I'll add it to the requirements and simplify the readme accordingly.

mentioned in commit e60b6ca9

For the record: the most crucial change in e60b6ca9 was to change

packages=find_packages(where="pyfstat"),

to just

packages=find_packages(),

to fix the following not-very-obvious but deadly output during python setup.py install:

warning: install_lib: 'build/lib.linux-x86_64-2.7' does not exist -- no Python modules to install

As of 6057a8ed this resulted in a fake-successful installation with "PyFstat" showing up under "pip list", but "import pyfstat" not working. I'm not sure if this was a case-sensitivity problem or something deeper, but the simplified version now seems to work for me.

Trying the same branch with python 2.7.13, I run into:

first

    ERROR: Command errored out with exit status 1:
     command: /home/dkeitel/programs/tcw-cnn-venv/bin/python2 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-0HlYvE/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-0HlYvE/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-req-build-0HlYvE/pip-egg-info                                                                                                                                      
         cwd: /tmp/pip-req-build-0HlYvE/                                                                                                                                                     
    Complete output (5 lines):                                                                                                                                                               
    Traceback (most recent call last):                                                                                                                                                       
      File "<string>", line 1, in <module>                                                                                                                                                   
      File "/tmp/pip-req-build-0HlYvE/setup.py", line 8, in <module>                                                                                                                         
        with open(path.join(here, "README.md"), encoding="utf-8") as f:                                                                                                                      
    TypeError: 'encoding' is an invalid keyword argument for this function                                                                                                                   
    ----------------------------------------                                                                                                                                                 
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

if removing that argument from setup.py:

Searching for scipy
Reading https://pypi.org/simple/scipy/
Downloading https://files.pythonhosted.org/packages/ee/5b/5afcd1c46f97b3c2ac3489dbc95d6ca28eacf8e3634e51f495da68d97f0f/scipy-1.3.1.tar.gz#sha256=2643cfb46d97b7797d1dbdb6f3c23fe3402904e3c90e6facfe6a9b98d808c1b5
Best match: scipy 1.3.1
[...]
  File "/tmp/easy_install-Al0_Lc/scipy-1.3.1/setup.py", line 31, in <module>
    "corner",
RuntimeError: Python version >= 3.5 required.

If fixing scipy==1.2.2 before, then

  File "/tmp/easy_install-SuXjcO/matplotlib-3.2.0rc1/setup.py", line 136
    raise IOError(f"Failed to download jquery-ui.  Please download "

and probably more errors would ensue if I keep trying.

@GregAshton @ReinhardPrix should we just deprecate python 2 for this package (and set an explicit minimum version in the setup), instead of investing energy into maintaining separate package requirements?

assigned to @GregAshton and unassigned @dkeitel

mentioned in merge request !23 (merged)

Yes, totally, I'm actually for setting the minimum to 3.7 or even the newly-released 3.8 and never looking back. Any python version can easily be installed either via pyenv or conda or similar ...

3.7 could be ok, while 3.8 is a bit too bleeding edge (e.g. no lalsuite wheels are built for it yet, see https://git.ligo.org/lscsoft/lalsuite/issues/212 ); but for the moment I'd prefer even 3.5 as the minimum (to keep Debian Stretch supported).

I just found out that the black style checker doesn't support 3.5 anymore, so yeah, I definitely have to admit that version is on its way out. I suggest we do one release after my current set of MRs with 3.5 as the minimum requirement, then immediately after bump to 3.6 for any further development work.

Btw, I (and the gitlab-runner) are using a setup with python 3.7.3 at the moment, and I've not seen any problems installing pyFstat and all tests pass as well. Which 'python 3' version were you using?

3.5.3 on my laptop with Debian Stretch (yes, that's old by now, but I'll only switch to Buster early next year when I get a new laptop anyway) and 3.6.8 on the Caltech cluster (which will presumably remain the default for a while).

Unless fixing the runner is easy, could you have a manual look at whether !23 (merged) is in any way problematic for 3.7.3?

Ok, !23 (merged) passes after your fix, thanks!

runner seems to be broken somehow at the moment ... looking into this

Thanks!

ok, runner seems to be working correctly again, the gitlab-runner setup on that machine was somewhat messed up indeed, so should be fixed now.

mentioned in commit 4188e542

mentioned in issue #20 (closed)

Merged !23 (merged) and split off the minimum version issue into #20 (closed).

closed

added bug meta labels