Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PyFstat
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

ATTENTION: This Gitlab instance will undergo extended maintenance on 2023-04-12 at 06:00 UTC. The downtime will approximately take 1 hour. Please plan ahead accordingly. For questions please contact atlas_admin@aei.mpg.de

  • Gregory Ashton
  • PyFstat
  • Merge requests
  • !25

ephemerides handling fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Keitel requested to merge ephem-handling into master Nov 05, 2019
  • Overview 4
  • Commits 9
  • Changes 5

@GregAshton 2 fixes to ephemerides handling:

  1. Fix a problem I introduced in !18 (merged) - for some reason I cannot remember (maybe just "high numbers look good") I picked DE421 as the standard to look for, while in lalapps it's currently actually DE405 for both CFSv2 and MFDv5.

  2. Teach Writer.run_makefakedata to actually pass through the chosen ephem files to the MFDv5 command line. The search class already properly handles them through InitBarycenter, while for making SFTs it seems we never actually did this properly so far.

I'll also need to add instructions for manual ephemerides download to the README, until a better way to provide those to pip users can be figured out; but I'll do that after !23 (merged) to avoid conflicts.

(fixed-up version of !24 (closed))

cc @ReinhardPrix in case you have opinions on the default version?

Edited Nov 05, 2019 by David Keitel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ephem-handling