Skip to content

ephemerides handling fixes

David Keitel requested to merge ephem-handling into master

@GregAshton 2 fixes to ephemerides handling:

  1. Fix a problem I introduced in !18 (merged) - for some reason I cannot remember (maybe just "high numbers look good") I picked DE421 as the standard to look for, while in lalapps it's currently actually DE405 for both CFSv2 and MFDv5.

  2. Teach Writer.run_makefakedata to actually pass through the chosen ephem files to the MFDv5 command line. The search class already properly handles them through InitBarycenter, while for making SFTs it seems we never actually did this properly so far.

I'll also need to add instructions for manual ephemerides download to the README, until a better way to provide those to pip users can be figured out; but I'll do that after !23 (merged) to avoid conflicts.

(fixed-up version of !24 (closed))

cc @ReinhardPrix in case you have opinions on the default version?

Edited by David Keitel

Merge request reports